-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: initial logical to physical compile #792
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This converts logical plans consisting of a tree of reference counted expressions into a physical execution plan. Also renames the scan operation to `read` and `table_id` to `source_id`. Work remaining in follow-ups: - Type-checking of the expressions in the physical plan. - Simplification pass to rewrite expressions within each step using arithmetic rules. - Projection pushdown pass to (a) move projections towards sources, allowing us to eliminate unnecessary columns, (b) combine projection steps. - Predicate pushdown pass to move `select` steps closer to sources.
bjchambers
changed the title
draft: feat: initial logical to physical compile
feat: initial logical to physical compile
Oct 5, 2023
jordanrfrazier
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cla-signed
Set when all authors of a PR have signed our CLA
enhancement
New feature or request
sparrow
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This converts logical plans consisting of a tree of reference counted expressions into a physical execution plan.
Also renames the scan operation to
read
andtable_id
tosource_id
.Work remaining in follow-ups:
select
steps closer to sources.