Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support lists in spread zip #793

Merged
merged 3 commits into from
Oct 5, 2023
Merged

feat: support lists in spread zip #793

merged 3 commits into from
Oct 5, 2023

Conversation

jordanrfrazier
Copy link
Collaborator

Uses the concat_take kernel to implement spread zip for lists, which should nested types as well.

We probably could simplify the spread_struct by using concat take too, and maybe even use that for primitives if it's performant.

Closes #788

@cla-bot cla-bot bot added the cla-signed Set when all authors of a PR have signed our CLA label Oct 4, 2023
@github-actions github-actions bot added enhancement New feature or request sparrow labels Oct 4, 2023
@jordanrfrazier jordanrfrazier added this pull request to the merge queue Oct 5, 2023
Merged via the queue into main with commit 74fa425 Oct 5, 2023
32 checks passed
@jordanrfrazier jordanrfrazier deleted the support-lists-in-spread-zip branch October 5, 2023 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjchambers bjchambers bjchambers approved these changes

Assignees
No one assigned
Labels
cla-signed Set when all authors of a PR have signed our CLA enhancement New feature or request sparrow
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: Unsupported type for spread_zip
2 participants
@jordanrfrazier @bjchambers