-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: compile and execute partitioned query #806
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
cla-signed
Set when all authors of a PR have signed our CLA
label
Oct 11, 2023
bjchambers
commented
Oct 11, 2023
bjchambers
commented
Oct 11, 2023
bjchambers
commented
Oct 11, 2023
bjchambers
commented
Oct 11, 2023
bjchambers
commented
Oct 11, 2023
bjchambers
commented
Oct 11, 2023
bjchambers
commented
Oct 11, 2023
bjchambers
commented
Oct 11, 2023
bjchambers
commented
Oct 11, 2023
bjchambers
commented
Oct 11, 2023
bjchambers
commented
Oct 11, 2023
bjchambers
commented
Oct 11, 2023
bjchambers
commented
Oct 11, 2023
bjchambers
commented
Oct 11, 2023
bjchambers
commented
Oct 11, 2023
bjchambers
commented
Oct 11, 2023
bjchambers
commented
Oct 11, 2023
bjchambers
commented
Oct 11, 2023
bjchambers
commented
Oct 11, 2023
bjchambers
commented
Oct 11, 2023
bjchambers
commented
Oct 11, 2023
bjchambers
commented
Oct 11, 2023
bjchambers
commented
Oct 11, 2023
bjchambers
commented
Oct 11, 2023
bjchambers
commented
Oct 11, 2023
bjchambers
force-pushed
the
partitioned-execution
branch
from
October 12, 2023 17:23
f23d6ac
to
24ccecb
Compare
bjchambers
commented
Oct 12, 2023
bjchambers
commented
Oct 12, 2023
bjchambers
force-pushed
the
partitioned-execution
branch
from
October 12, 2023 23:35
d4671bf
to
59f92c2
Compare
The main change here is having the `sparrow-execution` tests compile from a logical plan, created within a session, and execute things. Changes Include - Fix naming `field_ref` vs. `fieldref` (matches Python) - Tweak pipeline scheduling so that only transforms are grouped together. - Tweak pipelines so that each may output to multiple consumers - Introduces a `SourceTasks` so we can poll all inputs on a single tokio task. - Fixes to how the scheduler detects "completion" (empty queue isn't sufficient). TODO - [x] Actually execute the compiled query - [x] Connect to sources - [x] Move compilation / execution into session. - [x] Look at compiling out `tracing::trace` level statements. - [x] Look at running the query in the sessions tokio runtime - [ ] Move logical expr building to session (out of sparrow-logical) - [ ] Replace `ScalarValue` with arrows scalar? Literal too? - [ ] Look at suspending workers when queue is empty / waking on push - [ ] Look at a trait for logical functions (type-checking, compilation)
bjchambers
force-pushed
the
partitioned-execution
branch
from
October 12, 2023 23:36
59f92c2
to
d2d887c
Compare
...snapshots/sparrow_backend__logical_to_physical__tests__logical_to_physical_arithmetic-3.snap
Outdated
Show resolved
Hide resolved
bjchambers
changed the title
draft: feat: compile and execute partitioned query
feat: compile and execute partitioned query
Oct 17, 2023
jordanrfrazier
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cla-signed
Set when all authors of a PR have signed our CLA
enhancement
New feature or request
sparrow
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main change here is having the
sparrow-execution
tests compilefrom a logical plan, created within a session, and execute things.
Changes Include
field_ref
vs.fieldref
(matches Python)SourceTasks
so we can poll all inputs on a singletokio task.
sufficient).