Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: split up the expression crate #819

Merged
merged 4 commits into from
Oct 18, 2023
Merged

ref: split up the expression crate #819

merged 4 commits into from
Oct 18, 2023

Conversation

bjchambers
Copy link
Collaborator

This moves the traits for defining an expression evaluator into sparrow-interfaces and the code for executing a sequence of expressions into sparrow-expr-execution..

This allows flattening the sparrow-expressions crate, and only using it as a test dependency in a wide variety of places. It is only needed at execution time.

This is preparation for adding sparrow-aggregations to implement the stateful aggregations.

This moves the traits for defining an expression evaluator into
`sparrow-interfaces` and the code for executing a sequence of
expressions into `sparrow-expr-execution.`.

This allows flattening the `sparrow-expressions` crate, and only using
it as a test dependency in a wide variety of places. It is only needed
at execution time.

This is preparation for adding `sparrow-aggregations` to implement the
stateful aggregations.
@cla-bot cla-bot bot added the cla-signed Set when all authors of a PR have signed our CLA label Oct 17, 2023
.vscode/settings.json Outdated Show resolved Hide resolved
crates/sparrow-expressions/Cargo.toml Show resolved Hide resolved
@github-actions github-actions bot added the build label Oct 18, 2023
@bjchambers bjchambers added this pull request to the merge queue Oct 18, 2023
Merged via the queue into main with commit 1a0adcb Oct 18, 2023
13 checks passed
@bjchambers bjchambers deleted the ben/split-expressions branch October 18, 2023 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build cla-signed Set when all authors of a PR have signed our CLA refactor sparrow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants