ref: split up the expression crate #819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This moves the traits for defining an expression evaluator into `sparrow-interfaces` and the code for executing a sequence of expressions into `sparrow-expr-execution.`. This allows flattening the `sparrow-expressions` crate, and only using it as a test dependency in a wide variety of places. It is only needed at execution time. This is preparation for adding `sparrow-aggregations` to implement the stateful aggregations.
cla-bot
bot
added
the
cla-signed
jordanrfrazier
approved these changes
Oct 17, 2023
bjchambers
commented
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the traits for defining an expression evaluator into
sparrow-interfacesand the code for executing a sequence of expressions intosparrow-expr-execution..This allows flattening the
sparrow-expressionscrate, and only using it as a test dependency in a wide variety of places. It is only needed at execution time.This is preparation for adding
sparrow-aggregationsto implement the stateful aggregations.