feat: add source trait #2278
GitHub Actions / clippy
failed
Oct 11, 2023 in 0s
clippy
1 error
Details
Results
| Message level | Amount |
|---|---|
| Internal compiler error | 0 |
| Error | 1 |
| Warning | 0 |
| Note | 0 |
| Help | 0 |
Versions
- rustc 1.73.0 (cc66ad468 2023-10-03)
- cargo 1.73.0 (9c4383fb5 2023-08-26)
- clippy 0.1.73 (cc66ad4 2023-10-03)
Annotations
Check failure on line 37 in crates/sparrow-batch/src/row_time.rs
github-actions / clippy
an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true
error: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true
--> crates/sparrow-batch/src/row_time.rs:37:1
|
37 | impl Into<RowTime> for i64 {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into
= note: `-D clippy::from-over-into` implied by `-D warnings`
help: replace the `Into` implementation with `From<i64>`
|
37 ~ impl From<i64> for RowTime {
38 ~ fn from(val: i64) -> Self {
39 ~ RowTime(val)
|
Loading