-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rothschild: donate funds to external address with custom priority fee #482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dmitry Perchanov <[email protected]>
demisrael
force-pushed
the
rothchild-charity
branch
from
June 2, 2024 16:25
116d362
to
caecb67
Compare
Signed-off-by: Dmitry Perchanov <[email protected]>
coderofstuff
approved these changes
Sep 20, 2024
coderofstuff
requested changes
Sep 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code works as expected for send address and priority fee
minor comment
Signed-off-by: Dmitry Perchanov <[email protected]>
demisrael
force-pushed
the
rothchild-charity
branch
from
September 20, 2024 14:06
52ad92d
to
947d9b7
Compare
demisrael
force-pushed
the
rothchild-charity
branch
from
September 21, 2024 10:20
077f1a0
to
c3822e7
Compare
Signed-off-by: Dmitry Perchanov <[email protected]>
demisrael
force-pushed
the
rothchild-charity
branch
from
September 21, 2024 10:24
c3822e7
to
8003474
Compare
demisrael
changed the title
rothschild: donate funds to external address
rothschild: donate funds to external address with custom priority fee
Sep 21, 2024
coderofstuff
approved these changes
Sep 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use parameters:
[-a, --to-addr] kaspatest:xxxx to spend accumulated funds to donation wallet address.
[-f, --priority-fee] Transaction priority fee in SOMPS [default: 0]
[-r, --randomize-fee] Randomize transaction priority fee, used with -f, [0..priority-fee]