Fix CLI not showing incorrect URL on connect + add disconnect() before connect() #549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes incorrect URL displayed when using CLI and connecting to the public node infrastructure.
CLI does not use the resolver as a typical wRPC client does: if the connection terminates, CLI informs the user and stays disconnected requiring a manual connect. (whereas SDK-based use of resolver would reconnect based on supplied reconnect options).
As such, CLI uses the
urlsetting inwRPCclientconnect()options. This setting was not correctly updated inRpcCltinterface that provides external access to the connection descriptor (URL).In addition,
connect()now callsdisconnect()so that multipleconnect()requests (from SDKs or CLI) would disconnect the client if connected (instead of posting an error)