Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup legacy bip39 cfg flags interfering with docs.rs documentation builds #573

Merged
merged 2 commits into from
Sep 29, 2024
Merged

Cleanup legacy bip39 cfg flags interfering with docs.rs documentation builds #573

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
af038a6
cleanup legacy bip39 cfg that interferes with docs.rs builds
aspect Sep 29, 2024
ccf2072
Merge branch 'master' of github.com:aspectron/rusty-kaspa into bip39-cfg
aspect Sep 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion wallet/bip32/src/mnemonic/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ mod bits;
mod language;
mod phrase;

//#[cfg(feature = "bip39")]
pub(crate) mod seed;

pub use self::{language::Language, phrase::Mnemonic, phrase::WordCount};
2 changes: 0 additions & 2 deletions wallet/bip32/src/mnemonic/phrase.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,8 +229,6 @@ impl Mnemonic {
}

/// Convert this mnemonic phrase into the BIP39 seed value.
//#[cfg(feature = "bip39")]
//#[cfg_attr(docsrs, doc(cfg(feature = "bip39")))]
pub fn to_seed(&self, password: &str) -> Seed {
let salt = Zeroizing::new(format!("mnemonic{password}"));
let mut seed = [0u8; Seed::SIZE];
Expand Down
1 change: 0 additions & 1 deletion wallet/bip32/src/mnemonic/seed.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ use zeroize::Zeroize;

/// BIP39 seeds.
// TODO(tarcieri): support for 32-byte seeds
#[cfg_attr(docsrs, doc(cfg(feature = "bip39")))]
pub struct Seed(pub(crate) [u8; Seed::SIZE]);

impl Seed {
Expand Down