-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
modified one line in .get_timepoints_survsummary, to round cum.n.event #445
Conversation
@@ -4,3 +4,4 @@ | |||
.DS_Store | |||
docs/.DS_Store | |||
inst/doc | |||
*.swp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to be not needed....
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The git ignore change is probably a mistake. Could you please undo it?
Also you added a binary file which not sure if needed.
Maybe this is what preventing this important pull request from being approved...
@MaverickMeerkat , Thank you for taking a look at this. I agree that the gitignore change should not be included, but I am having trouble undoing it. Would you be able to either spell out exactly what I need to do, or just add the one useful line to .get_timepoints_survsummary another way? |
1 similar comment
@MaverickMeerkat , Thank you for taking a look at this. I agree that the gitignore change should not be included, but I am having trouble undoing it. Would you be able to either spell out exactly what I need to do, or just add the one useful line to .get_timepoints_survsummary another way? |
I opened a new pull request, because otherwise I think you would have needed to grant me permissions to change your own PR. It's here: #564 |
Closing this request, because @MaverickMeerkat has submitted a better one (many thanks!). |
Hi- thank you so much for this package. I added rounding in one line; you might also want to modify the line for cum.n.censor the same way.