Update ggcoxdiagnostics.R, fix for ox.scale = "time" and non unique eventtimes #468
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hope this is the correct place for this, as this is my first time really using Github.
Pleasantries first: This is a wonderful package and i'm very thankful for having it.
The issue
The following Code produces empty plots:
also it generates the following warning:
I could not find an issue for this problem, but it was also described here:
https://community.rstudio.com/t/ggcoxdiagnostics-warning-message/51867
My understanding of the problem and my solution
The introduction of NAs by Coercion happens in current line 92
with res being defined by
While
resid(fit, type = type)
returns an object with rownames that correspond to the sorted event-times, if the rownames are not unique the casting to data.frame will make them:The rownames of the data.frame then can't be converted to numeric. My Solution is to just keep the initial result
raw_res <- resid(fit, type = "schoenfeld")
to initiate xval.