Skip to content
This repository has been archived by the owner on Apr 2, 2021. It is now read-only.

add resp3 protocol part 4(protocol-string and render-string) #82

Merged
merged 1 commit into from
Aug 27, 2018

Conversation

chyroc
Copy link
Collaborator

@chyroc chyroc commented Aug 27, 2018

Pull Request for issue

#76

Description

Testing Instructions

Excepted Behavior

Actual Behavior

Additional Comments

@chyroc chyroc force-pushed the add-resp3-protocol-part-4 branch from e607bfd to 5df8522 Compare August 27, 2018 11:57
@codecov
Copy link

codecov bot commented Aug 27, 2018

Codecov Report

Merging #82 into master will increase coverage by 3.83%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #82      +/-   ##
==========================================
+ Coverage      73%   76.83%   +3.83%     
==========================================
  Files          11       11              
  Lines         800      833      +33     
==========================================
+ Hits          584      640      +56     
+ Misses        195      181      -14     
+ Partials       21       12       -9
Impacted Files Coverage Δ
internal/protcl/resp3.go 94.15% <100%> (+15.16%) ⬆️
internal/protcl/errors.go 29.41% <0%> (+11.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91f7cd8...5df8522. Read the comment docs.

@kasvith kasvith merged commit 6585325 into kasvith:master Aug 27, 2018
@kasvith
Copy link
Owner

kasvith commented Aug 27, 2018

Tnx

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants