Remove outdated ci #408
Merged
Remove outdated ci #408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These workflow are still using the hub cli which is outdated and we aren't actively managing the backlog especially in the community repo, so I don't think they work, or are required. Signed-off-by: stevenhorsman <[email protected]>
stevenhorsman
force-pushed
the
remove-outdated-ci
branch
12 times, most recently
from
b388800
to
45f72f3
Compare
gkurz
approved these changes
Oct 10, 2024
.ci/static-checks.sh
Outdated
| { | ||
| clone_kata_repo | ||
| INSTALL_IN_GOPATH=false bash "${kata_repo_dir}/ci/install_yq.sh" | ||
| bash "${kata_repo_dir}/tests/install_go.sh" -f -p |
There was a problem hiding this comment.
Eek - a mix of tabs and spaces in here 😱
.github/workflows/main.yml
Outdated
|
|
||
| - name: Running static checks | ||
| run: | | ||
| export PATH=${PATH}:${GOPATH}/bin |
There was a problem hiding this comment.
For extra safety, I'd put GOPATH/bin first.
The static checks were using the version from kata-containers, an old version of go and had a bunch of travis references that don't seem to be required any longer, so try updating this and removing the redundant code. Whether all these checks are useful is debatable, but at least now they should be up-to-date. Signed-off-by: stevenhorsman <[email protected]>
stevenhorsman
force-pushed
the
remove-outdated-ci
branch
from
45f72f3
to
587c0d1
Compare
fidencio
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove project issues workflows
These workflow are still using the hub cli which is outdated
and we aren't actively managing the backlog especially
in the community repo, so I don't think they work, or
are required.
Rework static checks
The static checks were using the version from kata-containers,
an old version of go and had a bunch of travis references that
don't seem to be required any longer, so try updating this
and removing the redundant code.
Whether all these checks are useful is debatable, but at least
now they should be up-to-date.