migration: Move from vanilla JS to Next.JS #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afinn12
reviewed
Oct 21, 2024
a1icja
changed the title
Redent0r
reviewed
Oct 23, 2024
Redent0r
reviewed
Oct 23, 2024
arc9693
reviewed
Oct 23, 2024
sprt
changed the title
sprt
requested changes
Oct 29, 2024
There was a problem hiding this comment.
Thank you @a1icja and team! I left a few comments.
One ask - if you scroll down to the bottom of the PR page, you'll find that we're failing the commit message check. Can you follow the contributing guidelines (the whole section up until Reviews, not just the first heading) and fix your PR? TLDR: Squash your commits into one, update the commit subject to match the new PR title, add a description and a signoff.
One question - do you know how hard it would be to be able to set up a staging website per PR to be able to test PRs publicly before merging them? Otherwise folks would have to manually checkout feature branches to test changes.
sprt
requested changes
Nov 4, 2024
This PR reimplements the features found in the dashboard using Next.js, TailwindCSS, and PrimeReact. It is not intended to be used for adding new features or fixing old bugs. Fixes kata-containers#14 Signed-off-by: Alicja Mahr <[email protected]>
sprt
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tl;dr - The dashboard has been rebuilt using Next.js, TailwindCSS, and PrimeReact (components library) to provide a better overall user and developer experience.
This PR reimplements the features found in the dashboard using Next.js. It is not intended to be used for adding new features or fixing old bugs.
Please see the
README.mdfile included in this PR for a general overview of how the project is formatted as well as information for how to setup a development environment.A live version of this dashboard with additional improvements and features (coming in future PRs) can be found here.
In order for this PR to be merged successfully, a couple things must happen:
Due to the significant changes present in this PR, please review each file carefully.