dashboard: small enhancements #20

afinn12 · 2024-11-05T21:13:18Z

Important

Review basePath changes in next.config.js. In local production deployment, changes were needed to work.
- (changes to basePath also made in deploy.yml)
Review Automatic Filter Note at bottom

Description

Changed basePath in next.config.js/deploy.yml
Added win-dev for Windows development
Upgrade Next.js version/include dotenv for dev
Simplified weatherTemplate.js
- weatherIcon is calculated by fails/runs instead of (fails+skips)/runs
- Removed getWeatherIcon
- Removed console.assert()
- Error check that idx is not > icons.length
index.js
- Moved total rows to the top of table
- Updated dev data to ../localData/job_stats.json (instead of ../job_stats.json)
- Filters automatically by most fails
Added files in /localData to .gitignore
fetch-ci-nighty-data.js
- added token to increase rate limits
- removed extra code for PR data
- reformat fetches --> show the status number and message
Updated readme with script/token instructions

Testing

Tested in dev
- TODO: BUG: In windows, running:
  node --require dotenv/config .\scripts\fetch-ci-nightly-data.js > localData\job_stats.json
- Will produce the error:
- This is caused by "> localData\job_stats.json" and has only been produced in windows dev
- Instead of > localData\job_stats.json, doing CTRL + C and CTRL + V from tmp-data.json to job_stats.json is a temporary solution that avoids these unexpected tokens.
Tested in prod
in prod (using build/start):

Automatic Filter Note

As seen above, the weather doesn't correlate with the number of fails (if a test was run more/less)

Sorting by weather produces:

This is less ideal because tests with only 1 run/fail are prioritized
- We are working on a solution to combine folder names with their contents, as these appear to be the "jobs" with one run.
- Q: Should we filter by fails or weather as the default?

a1icja

Definitely some changes that need to be made, but they're all minor

a1icja · 2024-11-06T17:17:50Z

.github/workflows/deploy.yml

Some context on the changes in this file:

This allows for us to have a staging instance by hosting in another repo without constantly modifying the code

components/weatherTemplate.js

next.config.js

package.json

pages/index.js

sprt

Thanks @afinn12! I left a few comments/questions.

For this PR, can you edit your commit message and list the same bullet points you listed in the PR description?

In future PRs (not this one), each such bullet point should be an individual commit (roughly, use your best judgement to split up into logical changes) to facilitate review. Potentially also split up into different PRs, as you'll notice that the review-correction cycle can delay merging: if you have multiple PRs, you can at least prioritize the features/PRs you want to get merged.

Crafting PRs is tricky! More info on this process here: https://github.com/kata-containers/community/blob/main/CONTRIBUTING.md#best-practices-for-patches
And some examples:
https://github.com/kata-containers/kata-containers/pull/10466/commits
https://github.com/kata-containers/kata-containers/pull/10038/commits

.github/workflows/deploy.yml

scripts/fetch-ci-nightly-data.js

sprt · 2024-11-07T20:26:38Z

README.md

+   Create the .env file:
+   ```bash
+    NODE_ENV=development
+    TOKEN=token <GITHUB_PAT_OR_OTHER_VALID_TOKEN>


Could you document or link to instructions on how to obtain this token?

Will update.

Do you know roughly how close we are to the new limit?

Current fetch count is 22 when I ran the script (very below limit, will increase with reruns)

.gitignore

pages/index.js

components/weatherTemplate.js

scripts/fetch-ci-nightly-data.js

pages/index.js

sprt · 2024-11-20T17:30:19Z

scripts/fetch-ci-nightly-data.js

+
+// Set token used for making Authorized GitHub API calls.
+// In dev, set by .env file; in prod, set by GitHub Secret.
+require('dotenv').config();


Need to guard this for GHA

Updated fetch script to require access token, simplified/removed extra PR code, and added error message. Modified basePath, styling change to weatherTemplate/table, added default sort by most Fails. Added win-dev/localData, updated README/.gitignore. Fixes: kata-containers#25 Signed-off-by: Anna Finn <[email protected]>

sprt · 2024-11-22T17:00:05Z

README.md

+   Create the folder /localData. Then, run:
+
+   ```bash
+   node scripts/fetch-ci-nightly-data.js > localData/job_stats.json


I'll do this in another PR.

Suggested change

node scripts/fetch-ci-nightly-data.js > localData/job_stats.json

node --require dotenv/config scripts/fetch-ci-nightly-data.js > localData/job_stats.json

sprt · 2024-11-22T17:01:53Z

.github/workflows/deploy.yml

+      - name: Build with Next.js (No base path)
+        if: ${{ env.NEXT_PUBLIC_BASE_PATH == '' }}
        run: ${{ steps.detect-package-manager.outputs.runner }} next build

+      - name: Build with Next.js (With base path)
+        if: ${{ env.NEXT_PUBLIC_BASE_PATH != '' }}
+        run: NEXT_PUBLIC_BASE_PATH=${{ env.NEXT_PUBLIC_BASE_PATH }} ${{ steps.detect-package-manager.outputs.runner }} next build


We don't need a condition here. I'll fix this in another PR.

afinn12 mentioned this pull request Nov 5, 2024

dashboard: Add filter for required tests #21

Merged

3 tasks

afinn12 marked this pull request as ready for review November 5, 2024 21:32

afinn12 mentioned this pull request Nov 5, 2024

dashboard: Add search box and link to URL #22

Open

3 tasks

afinn12 changed the title ~~Small enhancements~~ dashboard: small enhancements Nov 6, 2024

afinn12 force-pushed the small-enhancements branch from a80d308 to b396b29 Compare November 6, 2024 02:30

afinn12 mentioned this pull request Nov 6, 2024

dashboard: Add view for PR runs #23

Open

6 tasks

a1icja suggested changes Nov 6, 2024

View reviewed changes

afinn12 force-pushed the small-enhancements branch from 87e3b59 to 38c026b Compare November 6, 2024 17:46

afinn12 marked this pull request as draft November 6, 2024 18:22

afinn12 force-pushed the small-enhancements branch 2 times, most recently from f9ad24c to a82fb67 Compare November 7, 2024 00:35

a1icja force-pushed the small-enhancements branch from a82fb67 to 839eefc Compare November 7, 2024 01:18

afinn12 force-pushed the small-enhancements branch 2 times, most recently from 4f9b1e5 to fb38fc0 Compare November 7, 2024 16:49

afinn12 marked this pull request as ready for review November 7, 2024 17:04

afinn12 mentioned this pull request Nov 7, 2024

dashboard: Add Maintainers List #29

Merged

3 tasks

sprt requested changes Nov 7, 2024

View reviewed changes

sprt mentioned this pull request Nov 13, 2024

regression: Re-instate default sort of most failed jobs #25

Closed

afinn12 force-pushed the small-enhancements branch 2 times, most recently from 9dd9403 to 2613451 Compare November 18, 2024 20:15

This was referenced Nov 18, 2024

dashboard: Indicate if a test was rerun #30

Open

dashboard: Add single PR view #31

Open

afinn12 force-pushed the small-enhancements branch from 2613451 to c33d2e6 Compare November 19, 2024 20:05

sprt reviewed Nov 20, 2024

View reviewed changes

afinn12 force-pushed the small-enhancements branch from c33d2e6 to cea1d44 Compare November 21, 2024 19:52

sprt approved these changes Nov 22, 2024

View reviewed changes

sprt merged commit 2b7e4c2 into kata-containers:main Nov 22, 2024
1 check passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

dashboard: small enhancements #20

dashboard: small enhancements #20

afinn12 commented Nov 5, 2024 •

edited

Loading

a1icja left a comment

a1icja Nov 6, 2024

sprt left a comment

sprt Nov 7, 2024

afinn12 Nov 8, 2024

sprt Nov 11, 2024 •

edited

Loading

afinn12 Nov 18, 2024

sprt Nov 20, 2024

sprt Nov 22, 2024

sprt Nov 22, 2024

	node scripts/fetch-ci-nightly-data.js > localData/job_stats.json
	node --require dotenv/config scripts/fetch-ci-nightly-data.js > localData/job_stats.json

dashboard: small enhancements #20

dashboard: small enhancements #20

Conversation

afinn12 commented Nov 5, 2024 • edited Loading

Important

Description

Testing

Automatic Filter Note

a1icja left a comment

Choose a reason for hiding this comment

a1icja Nov 6, 2024

Choose a reason for hiding this comment

sprt left a comment

Choose a reason for hiding this comment

sprt Nov 7, 2024

Choose a reason for hiding this comment

afinn12 Nov 8, 2024

Choose a reason for hiding this comment

sprt Nov 11, 2024 • edited Loading

Choose a reason for hiding this comment

afinn12 Nov 18, 2024

Choose a reason for hiding this comment

sprt Nov 20, 2024

Choose a reason for hiding this comment

sprt Nov 22, 2024

Choose a reason for hiding this comment

sprt Nov 22, 2024

Choose a reason for hiding this comment

afinn12 commented Nov 5, 2024 •

edited

Loading

sprt Nov 11, 2024 •

edited

Loading