Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change default stat_prefix from ingress_http to arch #109

Merged
merged 2 commits into from
Oct 3, 2024
Merged

change default stat_prefix from ingress_http to arch #109

merged 2 commits into from
Oct 3, 2024

Conversation

aayushwhiz
Copy link
Contributor

changes the stat_prefix for http connection manager in envoy.template.yaml from ingress_http to arch.

@aayushwhiz aayushwhiz requested a review from adilhafeez October 1, 2024 22:48
adilhafeez
adilhafeez reviewed Oct 2, 2024
View reviewed changes
adilhafeez
adilhafeez approved these changes Oct 2, 2024
View reviewed changes
Copy link
Contributor

@adilhafeez adilhafeez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls address the feedback and then you can merge

adilhafeez
adilhafeez reviewed Oct 2, 2024
View reviewed changes
Copy link
Contributor

@adilhafeez adilhafeez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you pls verify the change and post the updated stats here

@aayushwhiz
Copy link
Contributor Author

aayushwhiz commented Oct 2, 2024 •
edited
Loading

image
The change looks like it's working on my end, just had to rebase the branch to test properly

@adilhafeez adilhafeez merged commit c8d0dbe into main Oct 3, 2024
2 checks passed
@junr03 junr03 deleted the change-stat_prefix-to-arch branch October 8, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adilhafeez adilhafeez adilhafeez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aayushwhiz @adilhafeez