Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infer port from protocol if port is not specified and add ability to override hostname in clusters def #389

Merged
merged 2 commits into from
Feb 3, 2025

Conversation

adilhafeez
Copy link
Contributor

@adilhafeez adilhafeez commented Feb 3, 2025

If port is not specified in endpoint then port will be inferred from protocol. For example in following arch_config we didn't specify port but the arch gateway inferred port 443 from protocol def,

arch_config.yaml

...
endpoints:
  frankfurther_api:
    endpoint: api.frankfurter.dev
    protocol: https
...

envoy.yaml

...
    - name: frankfurther_api
      connect_timeout: 5s
      type: LOGICAL_DNS
      dns_lookup_family: V4_ONLY
      lb_policy: ROUND_ROBIN
      load_assignment:
        cluster_name: frankfurther_api
        endpoints:
          - lb_endpoints:
              - endpoint:
                  address:
                    socket_address:
                      address: api.frankfurter.dev
                      port_value: 443

                  hostname: api.frankfurter.dev
...

@adilhafeez adilhafeez changed the title infer port from protocol if port is not specified Infer port from protocol if port is not specified and add ability to override hostname in clusters def Feb 3, 2025
@adilhafeez adilhafeez marked this pull request as ready for review February 3, 2025 22:41
@adilhafeez adilhafeez merged commit 962727f into main Feb 3, 2025
7 checks passed
adilhafeez added a commit that referenced this pull request Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants