Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encode parameter values in http path and ... #395

Merged
merged 4 commits into from
Feb 6, 2025

Conversation

adilhafeez
Copy link
Contributor

@adilhafeez adilhafeez commented Feb 6, 2025

  • don't send param values in request body in http get request
  • send param values in http post request
  • urlencode param values

For post request notice additional variables are sent as request body,

POST /v1/browse/new-releases/US HTTP/1.1
...
content-length: 13
...

{"limit":"5"}

And in case of GET you see empty body with all parms in request path

GET /v1/browse/new-releases/US?limit=5& HTTP/1.1
...

- don't send param values in request body in http get request
- send param values in http post request
@adilhafeez adilhafeez marked this pull request as ready for review February 6, 2025 08:44
@adilhafeez adilhafeez merged commit e82f8f2 into main Feb 6, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants