add k8s demo for api server #414
Draft
+184
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salmanap
reviewed
Feb 20, 2025
salmanap
requested changes
Feb 21, 2025
|
|
||
| Before starting make sure you have completed the pre-requisites [here](https://github.com/katanemo/archgw?tab=readme-ov-file#prerequisites) | ||
|
|
||
| In separate window start 1) model server, 2) arch gateway 3) docker container for UI and for debugging 4) tail access logs |
There was a problem hiding this comment.
model_server is our internal implementation detail - while they can run this in foreground. I am not sure why this example forces developers to run the demo using these commands. Someone looking at this demo will be confused between arch gateway and model_server.
Instead we should follow the pattern in all other demos. We could have an advanced "debug logs" demo
| @@ -0,0 +1,44 @@ | |||
| # Kubernetes API Demo | |||
|
|
|||
| This demo shows how you can use a publicly hosted REST API and interact with it using the Arch Gateway. | |||
There was a problem hiding this comment.
We should be more specific about the demo - interact with live APIs like the K8s control plane APIs using Arch Gateway
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.