Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand draggable functionality #59

Merged
merged 3 commits into from
Oct 2, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@kateter-platform/graphica-gemini",
"version": "1.0.5",
"version": "1.0.6",
"source": "./src/index.ts",
"description": "A tool for advanced graphing and visualization",
"license": "MIT",
Expand Down
16 changes: 13 additions & 3 deletions src/Components/Point.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,26 +8,30 @@ import {
Vector3,
} from "three";
import Text from "./Text";
import { Collider, Component, Draggable } from "./interfaces";
import { Collider, Component, DragListener, Draggable } from "./interfaces";

type PointOptions = {
label?: boolean;
decimals?: number;
color?: string;
draggable?: Draggable;
dragListeners?: ((point: Point) => void)[];
};

const defaultPointOptions = {
color: "#FAA307",
draggable: undefined,
decimals: 1,
label: false,
dragListeners: [],
};

class Point extends Component implements Collider {
class Point extends Component implements Collider, DragListener<Point> {
dragListeners: ((point: Point) => void)[];

constructor(x = 0, y = 0, options?: PointOptions) {
super();
const { color, draggable, decimals, label } = {
const { color, draggable, decimals, label, dragListeners } = {
...defaultPointOptions,
...options,
};
Expand All @@ -48,6 +52,7 @@ class Point extends Component implements Collider {
this.add(strokeMesh);
// set position of the mesh
this.position.set(x, y, 2);
this.dragListeners = dragListeners ?? [];

if (label) {
const text = new Text(
Expand All @@ -65,6 +70,10 @@ class Point extends Component implements Collider {
}
}

addDragListener(listener: (point: Point) => void) {
this.dragListeners.push(listener);
}

collidesWith(other: Object3D): boolean {
const box1 = new Box3().setFromObject(this);
const box2 = new Box3().setFromObject(other);
Expand Down Expand Up @@ -100,6 +109,7 @@ class Point extends Component implements Collider {
message: "Point has been moved",
position: this.position,
}); // Dispatch the drag event
this.dragListeners.forEach((fn) => fn(this));
}

update(camera: THREE.OrthographicCamera) {
Expand Down
31 changes: 25 additions & 6 deletions src/Components/Shape.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,18 +11,22 @@ import {
} from "three";
import { toVector2 } from "../utils";
import Line from "./Line";
import { Collider, Component } from "./interfaces";
import { Collider, Component, DragListener, Draggable } from "./interfaces";
import { InputPosition } from "./types";

export type PolygonOptions = {
color?: number;
fill?: boolean;
opacity?: number;
draggable?: Draggable;
dragListeners?: ((point: Polygon) => void)[];
};

export const defaultShapeOptions: PolygonOptions = {
color: 0xfaa307,
opacity: 0.6,
draggable: undefined,
dragListeners: [],
};

type PolygonVertices = [
Expand All @@ -32,16 +36,19 @@ type PolygonVertices = [
...InputPosition[]
];

class Polygon extends Component implements Collider {
draggable = undefined;
class Polygon extends Component implements Collider, DragListener<Polygon> {
vertices: PolygonVertices;
color: number;
object: Object3D;
dragListeners: ((value: Polygon) => void)[];

constructor(vertices: PolygonVertices, options?: PolygonOptions) {
super();

const { color, opacity } = { ...defaultShapeOptions, ...options };
const { color, opacity, draggable, dragListeners } = {
...defaultShapeOptions,
...options,
};

const shape = new Shape(vertices.map((e) => toVector2(e)));
const material = new MeshBasicMaterial({
Expand All @@ -53,8 +60,9 @@ class Polygon extends Component implements Collider {

const mesh = new Mesh(geometry, material);
mesh.scale.set(1, 1, 1);
this.add(mesh);
this.object = mesh;
this.geometry = mesh.geometry;
this.material = mesh.material;
this.position.setZ(1.5);

const group = new Group();
const lines = [];
Expand All @@ -74,7 +82,18 @@ class Polygon extends Component implements Collider {
this.object = group;
this.vertices = vertices;
this.color = color ?? 0xfaa307;
this.draggable = draggable;
this.dragListeners = dragListeners ?? [];
}

addDragListener(listener: (value: Polygon) => void) {
this.dragListeners.push(listener);
}

dragUpdate(): void {
this.dragListeners.forEach((fn) => fn(this));
}

collidesWith(other: Object3D): boolean {
const box1 = new Box3().setFromObject(this);
const box2 = new Box3().setFromObject(other);
Expand Down
6 changes: 6 additions & 0 deletions src/Components/interfaces.ts
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,12 @@ export interface Collider extends Object3D {
distanceTo(other: Object3D): number;
}

export interface DragListener<T> {
dragListeners: ((value: T) => void)[];
dragUpdate(): void;
addDragListener: (listener: (value: T) => void) => void;
}

export type ConstrainFunction = (x: number, y: number) => [number, number];

export type Draggable =
Expand Down
1 change: 0 additions & 1 deletion src/Controls/DragControls.ts
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,6 @@ class DragControls extends EventDispatcher {
}

this.dispatchEvent({ type: "drag", object: _selected });

return;
}

Expand Down
2 changes: 0 additions & 2 deletions src/Graphica.ts
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,6 @@ class Graphica {

dragControls.addEventListener("dragstart", function (event) {
controls.enabled = false;

const draggedObject = event.object;
draggedObject.is_dragged = true;
draggedObject.userData.initialPosition = draggedObject.position.clone();
Expand Down Expand Up @@ -170,7 +169,6 @@ class Graphica {

dragControls.addEventListener("dragend", function (event) {
controls.enabled = true;

const draggedObject = event.object;
draggedObject.is_dragged = false;
});
Expand Down
Loading