add firebase sdk 3.x support #112
Conversation
|
I added promise support to the authentication code using rsvp which is the same library the firebase sdk appears to use. Using a custom build with these changes, I was able to write passing authentication unit tests for the same project specified above:
@katowulf let me know if I'm going down the right path and I'll add new test cases to this PR |
removes need for stream-to-promise dependency
|
Would love to see Firebase 3.0 support merged in. Thank you! |
| @@ -52,10 +52,10 @@ | |||
| "karma-mocha": "~0.1.6", | |||
| "karma-phantomjs-launcher": "~0.1.4", | |||
| "karma-sinon": "~1.0.3", | |||
| "rsvp": "^3.2.1", | |||
There was a problem hiding this comment.
Hi, @soumak77. Thanks for this PR, I currently use your fork to test my tiny lib based on Firebase 3. You should move rsvp dependency from devDependencies to dependencies as rsvp is needed to run mockfirebase not to develop it.
There was a problem hiding this comment.
@anotherpit agreed, PR has been updated
|
@soumak77 Have you considered forking? |
|
@Grantlyk it's looking like I'll need to split this off into it's own repo. Hopefully I'll find the time in the coming weeks. |
|
@soumak77 Your work is appreciated, an update here would be good on how you get on with that, i'd be interested to use your finished product/contribute in some way |
|
I duplicated this repo as firebase-mock and published v1.0.0 with the firebase 3.0 changes. |
|
Thanks a ton @soumak77! It would be nice to get these changes merged back into this repo since it is the first mock library most find. |
|
Don't know if this helps anyone but ... I just created a pull request #98 for firebase/angularfire-seed that adds firebase-3.x and angularfire-2.x support - but without the mock-firebase unit tests working. I'm starting to look at firebase-mock to fix them all, but need to get my production system fixed first. May help out issue #109 too. Please let me know if anyone can help get the unit tests fixed - or even point me in the right direction. Thanks! |
|
@mkobar you can check out this angular template which uses firebase-mock |
|
These changes are available in https://github.com/soumak77/firebase-mock |
Adds basic database support to work with firebase sdk 3.x. Many more changes needed, but this is a start.
I added a custom build with these changes to the Firebase Template for Angular Base Apps. With these changes, the tests are now passing using Firebase SDK 3.x and AngularFire 2.x: