Skip to content

Commit

Permalink
Use named urls in reverse()
Browse files Browse the repository at this point in the history
  • Loading branch information
katur committed Jan 21, 2016
1 parent 9c66144 commit f519e96
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 10 deletions.
2 changes: 1 addition & 1 deletion birds/models.py
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ def __unicode__(self):
return self.common_name + ' (' + self.scientific_name + ')'

def get_absolute_url(self):
return reverse('birds.views.bird', args=[self.slug])
return reverse('bird_url', args=[self.slug])

def get_abc_bird_of_the_week_url(self):
url_name = self.common_name.replace(' ', '-')
Expand Down
15 changes: 7 additions & 8 deletions creations/models.py
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ def get_absolute_url(self):
if self.url:
return self.url
else:
return reverse('creations.views.article',
return reverse('article_url',
args=[self.id, slugify(self.title)])


Expand Down Expand Up @@ -113,7 +113,7 @@ def __unicode__(self):
return 'Book: ' + self.title

def get_absolute_url(self):
return reverse('creations.views.book', args=[self.slug])
return reverse('book_url', args=[self.slug])


class ExternalProject(Creation):
Expand Down Expand Up @@ -149,7 +149,7 @@ def __unicode__(self):
return 'Radio Program: ' + self.title

def get_absolute_url(self):
return reverse('creations.views.radio_program',
return reverse('radio_program_url',
args=[self.id, slugify(self.title)])

def get_display_date(self):
Expand Down Expand Up @@ -266,8 +266,7 @@ def __unicode__(self):
return self.name

def get_absolute_url(self):
return reverse('creations.views.research_category',
args=[self.id])
return reverse('research_category_url', args=[self.id])

def get_ancestors(self):
ancestors = []
Expand Down Expand Up @@ -297,7 +296,7 @@ def __unicode__(self):
return 'Research: ' + self.title

def get_absolute_url(self):
return reverse('creations.views.research_item', args=[self.id])
return reverse('research_item_url', args=[self.id])

def get_ancestors(self):
ancestors = [self.category]
Expand All @@ -316,7 +315,7 @@ def __unicode__(self):
return 'Speaking Program: ' + self.title

def get_absolute_url(self):
return reverse('creations.views.speaking_program', args=[self.slug])
return reverse('speaking_program_url', args=[self.slug])


class SpeakingProgramFile(models.Model):
Expand Down Expand Up @@ -351,7 +350,7 @@ def __unicode__(self):
return 'Web Page: ' + self.title

def get_absolute_url(self):
return reverse('creations.views.webpage', args=[self.slug])
return reverse('webpage_url', args=[self.slug])


class ABAFieldGuideImage(Creation):
Expand Down
2 changes: 1 addition & 1 deletion waystohelp/models.py
Original file line number Diff line number Diff line change
Expand Up @@ -21,4 +21,4 @@ def __unicode__(self):
return self.title

def get_absolute_url(self):
return reverse('waystohelp.views.way_to_help', args=[self.id])
return reverse('way_to_help_url', args=[self.id])

0 comments on commit f519e96

Please sign in to comment.