check_repo: ignore unpublished local changes #663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To allow force ignoring unpublished local changes as we might not be really publishing a release when running this action. Signed-off-by: Peng Tao <[email protected]>
bergwolf
force-pushed
the
github/check-repo
branch
from
6cc764a to
7dd35b6
Compare
katyo
reviewed
Aug 8, 2023
Comment on lines
61
to
+66
| package_errors = package_errors.filter( | ||
| ({kind}) => kind !== 'unable-to-get-commit-date' | ||
| ) | ||
| package_errors = package_errors.filter( | ||
| ({kind}) => kind !== 'has-unpublished-changes' | ||
| ) |
There was a problem hiding this comment.
What about merging both filters?
package_errors = package_errors.filter(
({kind}) => kind !== 'unable-to-get-commit-date' &&
kind !== 'has-unpublished-changes'
)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To allow force ignoring unpublished local changes as we might not be really publishing a release when running this action.