Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to Gradle implementation #1979

Merged
merged 1 commit into from
Mar 19, 2023

Conversation

ygpedroso
Copy link
Contributor

  • Starting on Gradle 7.0 the compile method is removed.
  • Trying to build an app making use of the compile method returns
    the following: > Could not find method compile() for arguments...
  • This change migrates compile instances in the Gradle config file
    to use implementation instead

- Starting on Gradle 7.0 the compile method is removed.
- Trying to build an app making use of the compile method returns
the following: > Could not find method compile() for arguments...
- This change migrates compile instances in the Gradle config file
to use implementation instead
@hussain-github
Copy link

Hi,

I installed the plugin with this commit, but I'm still getting the same error. It seems that Compile is used also in Cordova-Plugin-Badge which is a dependency for this plugin.

Any insights on this please.

@KumarSunil007
Copy link

@hussain-github You can install the updated badge plugin from Here

@GitToTheHub
Copy link
Collaborator

@ygpedroso Can be closed due to #2000 which contains this fix.

@GitToTheHub GitToTheHub merged commit 97cffd5 into katzer:master Mar 19, 2023
ParhamTaher added a commit to HitGrab/cordova-plugin-local-notifications that referenced this pull request Oct 27, 2023
commit eb0ac58
Merge: 97cffd5 7d21d76
Author: Manuel Beck <[email protected]>
Date:   Sun Mar 19 18:21:06 2023 +0100

    Merge pull request katzer#1973 from kumarsunil0007/patch-1

    Updated version for appShortcutBadger extenstion from 1.1.19 to 1.1.22

commit 97cffd5
Merge: ba42c73 e56ad35
Author: Manuel Beck <[email protected]>
Date:   Sun Mar 19 17:51:07 2023 +0100

    Merge pull request katzer#1979 from ygpedroso/bug/use-gradle-implementation

    Migrate to Gradle implementation

commit ba42c73
Merge: 6b30ca8 3c8e928
Author: Manuel Beck <[email protected]>
Date:   Sun Mar 19 17:46:13 2023 +0100

    Merge pull request katzer#1891 from timkellypa/android-10-updates

    Android 10 updates

commit 6b30ca8
Author: Manuel Beck <[email protected]>
Date:   Fri Mar 3 08:40:45 2023 +0100

    Update README.md

    Removed fund raising

commit d50a574
Author: Manuel Beck <[email protected]>
Date:   Tue Feb 28 17:33:19 2023 +0100

    Update README.md

    Added fundraising campaign for updating the plugin.

commit e56ad35
Author: Yannier <[email protected]>
Date:   Mon Aug 8 20:00:56 2022 -0400

    Migrate to Gradle implementation

    - Starting on Gradle 7.0 the compile method is removed.
    - Trying to build an app making use of the compile method returns
    the following: > Could not find method compile() for arguments...
    - This change migrates compile instances in the Gradle config file
    to use implementation instead

commit 7d21d76
Author: Sunil Kumar <[email protected]>
Date:   Tue May 3 11:18:41 2022 +0530

    Update localnotification.gradle

    Updated version for appShortcutBadger from 1.1.19 to 1.1.22

commit 3c8e928
Author: Tim Kelly <[email protected]>
Date:   Fri Jan 29 19:16:43 2021 -0500

    Fix "launchInApp" notifications in background

    - Dispatch a visibility change event on the webview.
    - Allows running of asynchronous code in webview (otherwise not working)
    - Remove no longer used checkAppInForeground() methods in receivers

commit 965d356
Author: Tim Kelly <[email protected]>
Date:   Tue Aug 4 21:43:25 2020 -0400

    Persist base date within trigger.

    - Store base date for repeating notifications that are rescheduled.
    - On reboot, do not fire high priority notifications that already fired.

commit 989f924
Author: Tim Kelly <[email protected]>
Date:   Thu Jul 30 00:21:52 2020 -0400

    Fix flag for scheduled alarm pending intent.

    - FLAG_UPDATE_CURRENT is better for clearing out old notifications.
    - FLAG_CANCEL_CURRENT can sometimes keep stale alarms around.

commit 613e0d8
Author: Tim Kelly <[email protected]>
Date:   Sun Jul 26 23:57:17 2020 -0400

    Fix volume configuration concurrency.

    - Handle multiple notifications firing simultaneously.
    - Refactor volume manager to new class.

commit f561c33
Author: Tim Kelly <[email protected]>
Date:   Mon Jul 13 18:19:34 2020 -0400

    Fix Android 8+ alarms when app is in background

    - When app is in background, system may not let it do async tasks.
    - Disable in app triggers when app is not in foreground.
    - This prevents inconsistent behavior with in app triggers

commit 74a8028
Author: Tim Kelly <[email protected]>
Date:   Tue Jun 16 22:19:18 2020 -0400

    Fix version to beta.4 in local-notification.js

commit 9689811
Merge: bda9b6e 32caf60
Author: timkellypa <[email protected]>
Date:   Tue Jun 16 22:10:46 2020 -0400

    Merge pull request #1 from kassamina/master

    AndroidManifest.xml can end up missing the config for local notifications

commit 32caf60
Author: Zoe <[email protected]>
Date:   Tue Jun 16 16:14:25 2020 -0400

    Add m0dch3n's fix for targeting the manifest

commit bda9b6e
Author: Tim Kelly <[email protected]>
Date:   Thu May 7 00:26:39 2020 -0400

    Minor fixes to restore receiver.

    - Remove clear.  No reason to clear a notification on restart.
    - Remove duplicate rescheduling logic.
    - If alarm is triggered on restore, performNotification reschedules it.

commit 802963c
Author: Tim Kelly <[email protected]>
Date:   Wed May 6 00:44:01 2020 -0400

    iOS bug fix.  Android restore receiver enhancement

    - Fix iOS schedule method to remove existing notification first.
    - Refactor Android receivers.
    - Create a base receiver with the logic for triggering a notification.
    - Extend that receiver for both restore and trigger.
    - Use same notification logic on boot as you do during a normal trigger.

commit 52002b0
Author: Tim Kelly <[email protected]>
Date:   Wed Apr 29 15:26:26 2020 -0400

    Fix isInteractive() call.

    - Should not be called at all on < Oreo.
    - Wasn't introduced until API 20, so threw errors on earlier versions.

commit 4472efe
Author: Tim Kelly <[email protected]>
Date:   Wed Apr 29 12:22:51 2020 -0400

    Bug fixes and added parameters

    - Added ability to use fullScreenIntent.
    - Fixed some things that were causing triggers not to fire.
    - Added ability to configure in-app triggers, decoupled from autoLaunch.
    - Default to immediately firing notifications
       - in instances where inapp triggers won't be reliably executed
       - based on Android version, sleep mode, etc.

commit 7721ecb
Author: Tim Kelly <[email protected]>
Date:   Thu Apr 16 01:50:12 2020 -0400

    Use AlarmClock for more exact high priority alarms

commit 3b63bf0
Author: Tim Kelly <[email protected]>
Date:   Mon Apr 13 23:29:23 2020 -0400

    Wakelock fixes.

    - Add longer timeout to wakelock.
    - Make wakelock timeout configurable (wakeLockTimeout)
    - Fix max priority notification on <M. Was not passing a wakeup flag.

commit 43f788b
Author: Tim Kelly <[email protected]>
Date:   Fri Apr 10 22:24:25 2020 -0400

    Use a more aggressive wakelock

    - This ensures timely firing when using an autoLaunch receiver.

commit 9aa59c1
Author: Tim Kelly <[email protected]>
Date:   Mon Apr 6 19:29:06 2020 -0400

    Fix typo in AssetUtil provider string

    - Typo prevented custom files from playing.

commit ef8cb32
Author: Tim Kelly <[email protected]>
Date:   Thu Apr 2 23:53:33 2020 -0400

    Add changelog for this branch.

commit 2b0a6b4
Merge: 876fb35 caff55e
Author: Tim Kelly <[email protected]>
Date:   Thu Apr 2 10:23:56 2020 -0400

    Merge branch 'master' into android-10-updates

    Pull changes from original repo (katzer).

commit 876fb35
Author: Tim Kelly <[email protected]>
Date:   Thu Apr 2 10:11:38 2020 -0400

    Android 10 updates

    - Updates to support Android 10 (device and SDK)
    - Change to androidx imports
    - Conditionally skip autoLaunch behavior on Android 10
    - Some bug fixes with channel naming and firing notifications.

    Firing Notifications if autoLaunch:
    - No longer fires notifications if autoLaunch is true.
    - In above case, trigger event should schedule an immediate notification
    - The intent is that it now can be conditional
    - Still fires notification immediately on Android 10 when app is closed

commit 211973d
Author: Tim Kelly <[email protected]>
Date:   Fri Oct 4 02:02:48 2019 -0400

    Change order in permissions section of readme.

commit 27a0bac
Author: Tim Kelly <[email protected]>
Date:   Fri Oct 4 01:51:17 2019 -0400

    Updates for wakelock, battery saving, and channels.

    - Update wakelock to acquire a partial lock for a second and not release.
    This allows it to run a small amount of async code in the trigger event.

    - Add methods to disable battery saving mode.
    This allows autolaunch alarms to fire more reliably.

    - Add channelId parameter, to allow caller to override channelId.
    (Was formerly always generated)

commit 10c6cdb
Author: timkellypa <[email protected]>
Date:   Thu Nov 1 22:46:14 2018 -0400

    Adding auto-launch capability for notifications in Android.
    Auto launches app and triggers an event.

commit 02832e9
Author: timkellypa <[email protected]>
Date:   Fri Oct 5 12:39:45 2018 -0400

    Added ability to customize alarm volume.
    - Added alarmVolume and resetDelay parameters.
    These let the caller specify the volume how long to stay at that
    volume before resetting.

    - Added requestDoNotDisturbPermissions and hasDoNotDisturbPermissions
    These allow the caller to check and request permissions to
    take the user out of silent (for an alarm volume config).  This
    also enables vibration when the phone is on silent (otherwise
    vibration and volume do not work on Android 8+).

commit 9c61255
Author: timkellypa <[email protected]>
Date:   Tue Oct 2 14:31:44 2018 -0400

    Added Android 8 Support for Sound and Vibrate properties.
    Created ability to have multiple channels
    generated dynamically for vibrate/sound configurations.
    * removed extra changes caused by creating a new branch *
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants