Optional led blinking and switch to remove notification on application kill #562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rors with different version of the library
…🍕. Led blinking is optional now.
|
Hi! Have these options been merged to the master branch? can I use them? It's important to have option to disable LED and vibration |
|
@mircoc may you could update your PR because there are merge conflicts. Tks! |
|
Hi @katzer, i updated my PR. Let me know! |
|
@mircoc Optional led and vibration have been added. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optional led blinking:
added a property for notification to disable led blinking (withLed: false)
Optional vibration:
added a property for notification to disable vibration (withVibration: false)
Switch to remove notification on application kill:
if setAutoClearAll() is called on plugin and the application is killed from android task manager than all notification will be removed