Solve 2021 day 01 #1
Conversation
| from pathlib import Path | ||
| from typing import Iterator | ||
|
|
||
| INPUT_FILE_PATH = Path('..', 'inputs', '1.txt') |
There was a problem hiding this comment.
Use __file__ instead of a relative path.
There was a problem hiding this comment.
Not sure how __file__ fits in here, could you explain?
| return sum(couple[1] > couple[0] for couple in couples) | ||
|
|
||
|
|
||
| def main(): |
There was a problem hiding this comment.
Write the I/O logic once, and for each problem implement only the pure logic: A function receiving the input as a string and returning the output as a string.
Then you can maybe think about an automation for running all the problems and uploading the results.
There was a problem hiding this comment.
I'm not sure it will be very helpful, getting the input from the file is one line. Or did you mean something else?
There was a problem hiding this comment.
And the main function and defining the file's locations and printing the result...
2021/d01/p1.py
Outdated
| :param measurements: measurements to parse | ||
| :return: count of the number of times a depth measurement increases | ||
| """ | ||
| couples = zip(measurements[:-1], measurements[1:]) |
There was a problem hiding this comment.
Thanks, after I finished my solution I found out there's a new pairwise function in itertools. Figured out if I was going to change something, better to use the new function already.
2021/d01/p2.py
Outdated
| _DEFAULT_WINDOW_SIZE = 3 | ||
|
|
||
|
|
||
| def get_measurements_windows(measurements: Iterator[int], window_size: int = _DEFAULT_WINDOW_SIZE) -> list[tuple[int]]: |
There was a problem hiding this comment.
Think how you can use zip for the general window size. Hint: argument list unpacking.
There was a problem hiding this comment.
Was 5675ce9 what you expected?
| from pathlib import Path | ||
| from typing import Iterator | ||
|
|
||
| INPUT_FILE_PATH = Path('..', 'inputs', '1.txt') |
There was a problem hiding this comment.
Not sure how __file__ fits in here, could you explain?
| return sum(couple[1] > couple[0] for couple in couples) | ||
|
|
||
|
|
||
| def main(): |
There was a problem hiding this comment.
I'm not sure it will be very helpful, getting the input from the file is one line. Or did you mean something else?
2021/d01/p1.py
Outdated
| :param measurements: measurements to parse | ||
| :return: count of the number of times a depth measurement increases | ||
| """ | ||
| couples = zip(measurements[:-1], measurements[1:]) |
There was a problem hiding this comment.
Thanks, after I finished my solution I found out there's a new pairwise function in itertools. Figured out if I was going to change something, better to use the new function already.
2021/d01/p1.py
Outdated
| INPUT_FILE_PATH = Path('..', 'inputs', '1.txt') | ||
|
|
||
|
|
||
| def get_measurements_from_input(input_text: str) -> list[int]: |
There was a problem hiding this comment.
| def get_measurements_from_input(input_text: str) -> list[int]: | |
| def get_measurements_from_input(input_text: str) -> list[int]:t |
2021/d01/p2.py
Outdated
| _DEFAULT_WINDOW_SIZE = 3 | ||
|
|
||
|
|
||
| def get_measurements_windows(measurements: Iterator[int], window_size: int = _DEFAULT_WINDOW_SIZE) -> list[tuple[int]]: |
There was a problem hiding this comment.
Was 5675ce9 what you expected?
No description provided.