Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing Virgo's arms directions #63

Merged
merged 1 commit into from
Jan 28, 2024
Merged

Conversation

tsunhopang
Copy link
Collaborator

Correcting the arms' orientations of Virgo within src/jimgw/single_detector/detector.py.

The previous setting is

V1 = GroundBased2G(
    "V1",
    latitude=(43 + 37.0 / 60 + 53.0921 / 3600) * DEG_TO_RAD,
    longitude=(10 + 30.0 / 60 + 16.1887 / 3600) * DEG_TO_RAD,
    xarm_azimuth=243.0 * DEG_TO_RAD,
    yarm_azimuth=333.0 * DEG_TO_RAD,
    xarm_tilt=0,
    yarm_tilt=0,
    elevation=51.884,
    mode="pc",
)

The corrected setting is

V1 = GroundBased2G(
    "V1",
    latitude=(43 + 37.0 / 60 + 53.0921 / 3600) * DEG_TO_RAD,
    longitude=(10 + 30.0 / 60 + 16.1887 / 3600) * DEG_TO_RAD,
    xarm_azimuth=70.5674 * DEG_TO_RAD,
    yarm_azimuth=160.5674 * DEG_TO_RAD,
    xarm_tilt=0,
    yarm_tilt=0,
    elevation=51.884,
    mode="pc",
)

which aligns with bilby's setting and the orientation of Virgo (shown on google map)

@tsunhopang
Copy link
Collaborator Author

The fix should only have a minimal impact on the published results. Since
i) For injection study, the injection and recovery are consistently using the "modified" Virgo
ii) For real events, only GW170817 can be affected. Yet, the SNR in Virgo is minimal as compared to the two LIGO detectors (see here), so the posterior of psi is still minimally impacted.

@kazewong kazewong self-requested a review January 28, 2024 12:47
@kazewong kazewong merged commit a1908dc into kazewong:main Jan 28, 2024
5 of 7 checks passed
@tsunhopang tsunhopang deleted the bugfix_V1_arms branch January 28, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants