Cleaned hyperparams and save hyperparams feature #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for updating the API. Would you mind going through the pre-commit to make sure the code is formatted correctly? |
|
Sure! I will get back to you ASAP with the fixed formatting |
added 2 commits
February 20, 2024 23:18
|
This needs to be checked again with the jim version update, I will close it for now and get back to it later on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small PR to clean up the hyperparameter treatment to make it similar to flowMC's.
Also added a small function that saves the hyperparameter values used for both flowMC as well as jim to a JSON file, for reproducibility of jim runs. Let me know if you think this is useful to have.