-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Time and phase marginalization #71
Merged
kazewong
merged 11 commits into
kazewong:main
from
tsunhopang:time-phase-marginalization
Feb 22, 2024
Merged
Changes from 4 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
42760db
initial commit for marginalization
tsunhopang c7f15e2
Further commit for the marginalization
tsunhopang d476e68
Switching to positive frequency only
tsunhopang 145b41a
Fixing conflict
tsunhopang 7444f19
Merge branch 'main' into time-phase-marginalization
kazewong 0cbf45c
Move internel likelihood function from utils.py to likelihood.py.
kazewong 20c52ff
bypassing yaml type check
kazewong 65fd208
Allowing the reference parameters for Heterodyned likelihood to be pr…
tsunhopang d5496ba
Initial commit of adding phase marginalization in relative binning li…
tsunhopang c8ae3f2
Minor fix
ee7489a
Adjusting the reference parameter's eta in case it is too close to 0.25
tsunhopang File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer to put the likelihood function in the
likelihood.py
file instead ofutils.py
. You can leave the logi0 in.