Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor changes for priors & adding prerequisite #90

Merged
merged 21 commits into from
Jul 22, 2024
Merged

Minor changes for priors & adding prerequisite #90

merged 21 commits into from
Jul 22, 2024

Conversation

thomasckng
Copy link
Collaborator

@thomasckng thomasckng commented Jul 11, 2024 •
edited
Loading

Consistent parameter ordering. Zenith always comes before azimuth.

@thomasckng
Copy link
Collaborator Author

Added jaxtyping as prerequisite. Older versions do not support typechecker argument.

@thomasckng thomasckng changed the title Consistent parameter ordering Consistent parameter ordering & adding prerequisite Jul 11, 2024
@thomasckng
Copy link
Collaborator Author

thomasckng commented Jul 11, 2024 •
edited
Loading

Added some more prerequisites. Python 3.9 doesn't have flowMC 0.3 yet, so it is failing, but I think it is necessary.

@thomasckng thomasckng changed the title Consistent parameter ordering & adding prerequisite Minor changes for EarthFrame prior & adding prerequisite Jul 11, 2024
@thomasckng
Copy link
Collaborator Author

Use SingleEventRun object trigger_time and ifos directly when EarthFrame prior is called via SingleEventPERunManager.

@thomasckng thomasckng changed the title Minor changes for EarthFrame prior & adding prerequisite Minor changes for priors & adding prerequisite Jul 11, 2024
@thomasckng
Copy link
Collaborator Author

Consistent data type for Sphere prior __init__ input

@kazewong kazewong merged commit 2a51d8c into kazewong:main Jul 22, 2024
2 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kazewong kazewong kazewong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thomasckng @kazewong