Development #1
Open
Development #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meheedihasaan
approved these changes
Dec 13, 2024
| user.setRole("ROLE_USER"); | ||
| user.setEnabled(true); | ||
| user.setImageUrl("default.png"); | ||
| User saved = userRepository.save(user); |
There was a problem hiding this comment.
Write a function in UserService to register user. Call this function from this controller.
| @@ -15,11 +17,17 @@ public class User { | |||
| @GeneratedValue(strategy = GenerationType.AUTO) | |||
| private Long id; | |||
|
|
|||
| @NotBlank(message = "Name is required") | |||
There was a problem hiding this comment.
Bhai, it will be better if you use a SignUp request and apply these validation annotation there.
| private String name; | ||
|
|
||
| @NotBlank(message = "Email is required") | ||
| @Size(max = 100) | ||
| @Column(unique = true) |
There was a problem hiding this comment.
Use @Email annotation to validate the email.
| @Override | ||
| public UserDetails loadUserByUsername(String username) throws UsernameNotFoundException { | ||
|
|
||
| User user = userRepository.findByEmail(username); |
There was a problem hiding this comment.
Email can be case-insensitive. So, it is better to use findByEmail with ignore case.
| @@ -25,7 +25,7 @@ | |||
| <a class="nav-link" th:href="@{/about}">About</a> | |||
| </li> | |||
| <li class="nav-item"> | |||
| <a class="nav-link" th:href="@{/login}">Login</a> | |||
| <a class="nav-link" th:href="@{/sign-in}" >Sing In</a> | |||
| </li> | |||
| <li class="nav-item"> | |||
| <a class="nav-link" th:href="@{/signup}">Signup</a> | |||
There was a problem hiding this comment.
Please correct this as /sign-up
| @@ -35,8 +42,17 @@ public String userDashboard(Model model) { | |||
| } | |||
|
|
|||
| @GetMapping(value = "/add-contact") | |||
There was a problem hiding this comment.
Create a ContactController and then write all the contact related operation inside the controller.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.