Add more documentation #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tianhao-Gu
approved these changes
Feb 12, 2024
Co-authored-by: Tianhao Gu <[email protected]>
This sets the IN_CONTAINER as part of the image so it will be set automatically.
The job_id was null which causes problems.
bio-boris
requested changes
Feb 13, 2024
bio-boris
reviewed
Feb 13, 2024
bio-boris
reviewed
Feb 13, 2024
bio-boris
reviewed
Feb 13, 2024
Add Boris's suggestions Co-authored-by: bio-boris <[email protected]>
bio-boris
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should we add documentation on EE2 deployment here as well or anything about how to get variables from EE2 into this? or maybe in a separate issue?