Skip to content

UIP-35, URO-95: Europa legacy-kbase-ui image #1661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Conversation

dakotablair
Copy link

@dakotablair dakotablair commented Nov 29, 2023

Pull Request

Description

Bringing release image up to date with the old main branch, which includes GA4 configuration.

Issues Resolved

Testing Instructions

  • Tests pass locally
  • Tests pass in github actions
  • Manually verified that changes area available

Dev Checklist

  • Code follows the guidelines at https://sites.google.com/truss.works/kbasetruss/development
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Integration tests have been run and fully pass (only when preparing a release)
  • I have run run the code quality script against the codebase (also done implicitly during a build)

Release Notes

  • Ensure there is an "upcoming release notes" file located in release-notes/RELEASE_NOTES_NEXT.md
  • Add relevant notes to this document

@dakotablair dakotablair changed the title UIP-35, URO-95 UIP-35, URO-95: Europa legacy-kbase-ui image Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants