Update to V10

[ChiefMilesEdgeworth]

There's a lot of changes in this, so I'll try and break it down as best I can remember.

• Variable paths which used data no longer do, as this is not required (and throws a warning).
• Updating image paths now updates the tile directly rather than going through the canvas.
• Animation took some work to fix, so more bullet points.
  • Removed {start/stop/stopAll}animationGM() functions. Now the regular functions just check if the user is the first GM.
  • Removed communication over the socket for animation as well
  • Animation is no longer done using canvas.app.ticker, instead it uses setInterval(). This is because rotating a tile is no longer synchronous, so using the ticker produced strange behavior
  • The "Interval" field is now "Speed". It is a multiplier for how fast the animation should move. By default it performs one full rotation in one minute.
• Tiles maintain their rotational position through movement (I don't remember if they used to do this or not).
• Places that directly referenced "turnmarker" in the scripts now use modName.

Overall the transition was fairly easy, though it took some work to coax the animation into working properly.
I bumped the version to 2.10, but I don't know how to make a release so that'll probably need done with this assuming it gets merged. If there's updates that need to be made to the manifest as well, I'm happy to make those. This is my first time contributing to a foundry module.

Please let me know if there's anything else I can do to help this through, I really love the simplicity of this module and seeing it didn't work on V10 almost kept me from upgrading.

Closes #104
Closes #105
(hopefully)

[TheMathKing]

This is an essential module, so I truly hope that these fixes work. I would try to integrate them into my build, but I can't really install it right now. Also, thanks for the work!

[TheMathKing]

I managed to install it and try it out in V10.286 and I get this error when it is the turn of a token:

utils.js:32 Uncaught (in promise) TypeError: game.users.entities is not iterable
[Detected 1 package: turnmarker]
at c (utils.js:32)
at d (turnmarker.js:212)
at Object.fn (turnmarker.js:96)
at Function.#call (foundry.js:724)
at Function.callAll (foundry.js:681)
at ClientDatabaseBackend.callback (foundry.js:12712)
at foundry.js:12660
at Array.map ()
at ClientDatabaseBackend._handleUpdateDocuments (foundry.js:12660)
at ClientDatabaseBackend._updateDocuments (foundry.js:12537)
at async Function.updateDocuments (commons.js:6120)
at async Combat.update (commons.js:6217)
at async CombatTracker._onCombatControl (foundry.js:74342)

[ChiefMilesEdgeworth]

Hmm. I'm not hitting that error. Also, this module seems to also do a good job of this, and is updated for V10, if you're looking for something to use in the meantime.

[karpana]

@ChiefMilesEdgeworth
Thank you for your efforts in puling these updates together.
I've done some manual kung-fu in my v10 test folder (I haven't updated to v10 yet, but plan to this week), to use your updates (from your git fork) and your updates are working fanstastically!

Here's to hoping that @kckaiwei can merge your pull request and create a release for everybody!

[TyrasNistru]

Seems legit.

Fixes the warnings about the data structure, and the mentions to missing files. Works OK.

[coffiarts]

Hmm. I'm not hitting that error. Also, this module seems to also do a good job of this, and is updated for V10, if you're looking for something to use in the meantime.

This looks really nice :) ... only that it supports dnd5e only. Users of other systems will have to stick to Turn Marker and hope for it to get fixed ;-)

[ChiefMilesEdgeworth]

Yeah, I've since switched to that module as well.

[joaobarcia]

Same here, I love this module and miss it a lot since upgrading to v10. Also, we don't play DnD. Thanks for all the efforts!

[karpana]

Same here, I love this module and miss it a lot since upgrading to v10. Also, we don't play DnD. Thanks for all the efforts!

This looks really nice :) ... only that it supports dnd5e only. Users of other systems will have to stick to Turn Marker and hope for it to get fixed ;-)

@joaobarcia, @coffiarts and others ...
While we wait for TurnMarker to get updated properly, the alternate that was propsoed ... works wonderfully, even if not using DnD. I'm a PF1E GM, and it's meeting my needs.

[karpana]

reviewed all the changes.
things look reasonable, and consistent with fvtt v10 changes. nothing untoward added, and a tad bit of code re-architecting.

[illandril]

For any late v10 upgraders who come across this issue, here are two alternative modules that provide similar functionality:

• Combat Booster
• Illandril's Turn Marker