Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix advanced resolver walk_list_if_item_expr #1018

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

He1pa
Copy link
Contributor

@He1pa He1pa commented Feb 1, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

2. What is the scope of this PR (e.g. component or file name):

kclvm/sema/src/advanced_resolver/node.rs

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

@He1pa He1pa added semantic Issues or PRs related to kcl semantic and checker lsp labels Feb 1, 2024
Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link
Collaborator

coveralls commented Feb 1, 2024

Pull Request Test Coverage Report for Build 7738660454

  • 0 of 3 (100.0%) changed or added relevant lines in 2 files are covered.
  • 241 unchanged lines in 8 files lost coverage.
  • Overall coverage decreased (-15.5%) to 72.276%

Files with Coverage Reduction New Missed Lines %
compiler_base/error/src/diagnostic/diagnostic_message.rs 3 0.0%
compiler_base/error/src/diagnostic/components.rs 6 0.0%
compiler_base/error/src/errors.rs 8 0.0%
compiler_base/error/src/diagnostic/diagnostic_handler.rs 11 0.0%
compiler_base/session/src/lib.rs 26 58.06%
compiler_base/error/src/diagnostic/mod.rs 27 0.0%
compiler_base/error/src/diagnostic/style.rs 41 0.0%
compiler_base/error/src/emitter.rs 119 0.0%
Totals Coverage Status
Change from base Build 7720914610: -15.5%
Covered Lines: 43767
Relevant Lines: 60555

💛 - Coveralls

@Peefy Peefy merged commit 6e44d3e into kcl-lang:main Feb 1, 2024
9 of 11 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lsp semantic Issues or PRs related to kcl semantic and checker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants