Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enhance builtin func complete #1064

Merged
merged 2 commits into from
Feb 21, 2024

Conversation

He1pa
Copy link
Contributor

@He1pa He1pa commented Feb 21, 2024

  1. Complete builtin function in root scope and lambda scope.
  2. Modify the label of the function's completion item to avoid fuzzy matching of function parameters to commonly used characters, such as x,y,z, and migrate function parameter descriptions to completion item detail
  3. Remove duplicate functions

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

2. What is the scope of this PR (e.g. component or file name):

kclvm/tools/src/LSP/src/completion.rs

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

…function in root scope. 2. Modify the label of the function's completion item to avoid fuzzy matching of function parameters to commonly used characters, such as x,y,z, and migrate function parameter descriptions to completion item detail

Signed-off-by: he1pa <[email protected]>
@He1pa He1pa added the lsp label Feb 21, 2024
@He1pa He1pa self-assigned this Feb 21, 2024
@coveralls
Copy link
Collaborator

coveralls commented Feb 21, 2024

Pull Request Test Coverage Report for Build 7986535532

Details

  • -22 of 65 (66.15%) changed or added relevant lines in 2 files are covered.
  • 14 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 71.815%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/tools/src/LSP/src/completion.rs 42 64 65.63%
Files with Coverage Reduction New Missed Lines %
kclvm/tools/src/LSP/src/request.rs 14 66.44%
Totals Coverage Status
Change from base Build 7986101701: -0.02%
Covered Lines: 44273
Relevant Lines: 61649

💛 - Coveralls

Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit 88f4c2c into kcl-lang:main Feb 21, 2024
7 of 8 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants