-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: upgrade dict type into schema type #1350
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Peefy
reviewed
May 22, 2024
Add some comments and grammar test failed in CI. |
He1pa
force-pushed
the
upgrade_dict_to_schema_ty
branch
from
May 22, 2024 11:59
48e7705
to
f3603e0
Compare
Peefy
reviewed
May 23, 2024
Peefy
reviewed
May 24, 2024
…ected type is schema Signed-off-by: he1pa <[email protected]>
…context instead Signed-off-by: he1pa <[email protected]>
Signed-off-by: he1pa <[email protected]>
…rying to upgrade dict into schema Signed-off-by: he1pa <[email protected]>
Signed-off-by: he1pa <[email protected]>
He1pa
force-pushed
the
upgrade_dict_to_schema_ty
branch
from
May 24, 2024 05:15
038bffe
to
3b08dbe
Compare
Peefy
reviewed
May 24, 2024
Peefy
reviewed
May 24, 2024
Pull Request Test Coverage Report for Build 9219335168Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Signed-off-by: he1pa <[email protected]>
Peefy
approved these changes
May 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
upgrade dict type into schema type in node_ty_map if expr's expected type is schema
1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):
2. What is the scope of this PR (e.g. component or file name):
kclvm/sema/src/advanced_resolver/node.rs
kclvm/sema/src/resolver/node.rs
3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):
4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):
5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links: