Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nest schema expr type check #1475

Merged
merged 2 commits into from
Jul 4, 2024

Conversation

He1pa
Copy link
Contributor

@He1pa He1pa commented Jul 4, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

2. What is the scope of this PR (e.g. component or file name):

kclvm/sema/src/advanced_resolver/mod.rs
kclvm/sema/src/resolver/config.rs
kclvm/sema/src/resolver/ty.rs

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • scan all schema symbol before advanced_resolver resolve program
  • enhance scehma index signature check
  • fix find_schema_attr_obj_from_schema_expr_stack
  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

@Peefy
Copy link
Contributor

Peefy commented Jul 4, 2024

You can rebase the main branch and fix the CI errors.

@Peefy Peefy merged commit 4a5951e into kcl-lang:main Jul 4, 2024
7 of 11 checks passed
shruti2522 pushed a commit to shruti2522/kcl that referenced this pull request Jul 5, 2024
* fix: fix nest schema expr type check

Signed-off-by: he1pa <[email protected]>

* fix: fix schema index signature check and schema symbol init in advanced_resolver

Signed-off-by: he1pa <[email protected]>

---------

Signed-off-by: he1pa <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants