Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GetVersion method to public API #1479

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

bozaro
Copy link
Contributor

@bozaro bozaro commented Jul 8, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

2. What is the scope of this PR (e.g. component or file name):

kclvm/api/src/service/service_impl.rs,
kclvm/spec/gpyrpc/gpyrpc.proto

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

Add GetVersion method to public API to allow get kclvm binary version from client application.

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

Minimal test as GetVersion example code (passed by cargo test --doc)

Signed-off-by: Artem V. Navrotskiy <[email protected]>
Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing Job! LGTM!

@coveralls
Copy link
Collaborator

coveralls commented Jul 8, 2024

Pull Request Test Coverage Report for Build 9834944139

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 1 of 24 (4.17%) changed or added relevant lines in 3 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.03%) to 71.376%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/api/src/service/capi.rs 1 8 12.5%
kclvm/api/src/service/jsonrpc.rs 0 8 0.0%
kclvm/api/src/service/service_impl.rs 0 8 0.0%
Files with Coverage Reduction New Missed Lines %
kclvm/tools/src/LSP/src/inlay_hints.rs 3 79.22%
Totals Coverage Status
Change from base Build 9834319156: -0.03%
Covered Lines: 56563
Relevant Lines: 79246

💛 - Coveralls

@Peefy Peefy merged commit 1a9a729 into kcl-lang:main Jul 8, 2024
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants