Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: evaluator schema config resolve with parent schemas #1490

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Jul 12, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y
  • fix: evaluator schema config resolve with parent schemas
  • fix: unix package release tarball format

@coveralls
Copy link
Collaborator

coveralls commented Jul 12, 2024

Pull Request Test Coverage Report for Build 9900128815

Details

  • 43 of 63 (68.25%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.3%) to 71.693%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/evaluator/src/schema.rs 9 18 50.0%
kclvm/evaluator/src/scope.rs 7 18 38.89%
Totals Coverage Status
Change from base Build 9893525750: 0.3%
Covered Lines: 56961
Relevant Lines: 79451

💛 - Coveralls

Copy link
Contributor

@zong-zhe zong-zhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit e765674 into kcl-lang:main Jul 12, 2024
12 of 13 checks passed
@Peefy Peefy deleted the fix-evaluator-schema-config-resolve branch July 12, 2024 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants