Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix call arg symbol pos #1494

Merged
merged 3 commits into from
Jul 12, 2024
Merged

fix: fix call arg symbol pos #1494

merged 3 commits into from
Jul 12, 2024

Conversation

He1pa
Copy link
Contributor

@He1pa He1pa commented Jul 12, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

2. What is the scope of this PR (e.g. component or file name):

kclvm/sema/src/advanced_resolver/node.rs

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

fix call arg symbol position

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But CI failed on unit tests.

Signed-off-by: he1pa <[email protected]>
Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy
Copy link
Contributor

Peefy commented Jul 12, 2024

CI failed on the loader crate.

Signed-off-by: he1pa <[email protected]>
@coveralls
Copy link
Collaborator

coveralls commented Jul 12, 2024

Pull Request Test Coverage Report for Build 9906238256

Details

  • 4 of 4 (100.0%) changed or added relevant lines in 3 files are covered.
  • 6 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.003%) to 71.779%

Files with Coverage Reduction New Missed Lines %
kclvm/sema/src/core/symbol.rs 6 51.2%
Totals Coverage Status
Change from base Build 9902619566: -0.003%
Covered Lines: 57223
Relevant Lines: 79721

💛 - Coveralls

@Peefy Peefy merged commit 408f4c4 into kcl-lang:main Jul 12, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Keyword arguments and positional arguments of functions have different highlighting effects on strings.
3 participants