Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: list index union operation #1507

Merged
merged 2 commits into from
Jul 17, 2024
Merged

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Jul 17, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

fix #1503

fix: list index union operation

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other
  • Unit tests:
    • kclvm/evaluator/src/union.rs
    • kclvm/runtime/src/value/value_union.rs
  • Grammar tests: test/grammar/attr_operator/list_index/**

Copy link
Contributor

@zong-zhe zong-zhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit 44709e4 into kcl-lang:main Jul 17, 2024
11 of 12 checks passed
@Peefy Peefy deleted the fix-list-index-union-op branch July 17, 2024 10:02
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 9971858927

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 221 of 443 (49.89%) changed or added relevant lines in 20 files are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.1%) to 71.664%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/compiler/src/codegen/traits/value.rs 1 2 50.0%
kclvm/evaluator/src/calculation.rs 14 15 93.33%
kclvm/evaluator/src/ty.rs 0 1 0.0%
kclvm/runtime/src/value/val_schema.rs 4 5 80.0%
kclvm/runtime/src/value/val_type.rs 0 1 0.0%
kclvm/evaluator/src/schema.rs 1 3 33.33%
kclvm/runtime/src/stdlib/builtin.rs 0 2 0.0%
kclvm/runtime/src/value/val_clone.rs 2 4 50.0%
kclvm/runtime/src/value/val_dict.rs 14 21 66.67%
kclvm/runtime/src/value/val_list.rs 0 7 0.0%
Files with Coverage Reduction New Missed Lines %
kclvm/runtime/src/value/val_dict.rs 1 57.82%
kclvm/evaluator/src/union.rs 2 36.99%
Totals Coverage Status
Change from base Build 9968523818: -0.1%
Covered Lines: 57254
Relevant Lines: 79892

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Wrong execution result for merge operator of list index
3 participants