Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: dict upgrade schema type and check #1531

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Aug 1, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

re #1527

  • refactor: dict upgrade schema type and check

@Peefy Peefy force-pushed the enhance-dict-upgrade-schema-ty branch from a7eeb77 to d773868 Compare August 1, 2024 09:43
@Peefy Peefy requested review from He1pa and zong-zhe August 1, 2024 09:48
@Peefy Peefy added this to the v0.10.0 Release milestone Aug 1, 2024
Copy link
Contributor

@He1pa He1pa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link
Collaborator

coveralls commented Aug 1, 2024

Pull Request Test Coverage Report for Build 10195951378

Details

  • 159 of 178 (89.33%) changed or added relevant lines in 10 files are covered.
  • 6 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.001%) to 70.307%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/sema/src/resolver/global.rs 1 2 50.0%
kclvm/tools/src/LSP/src/to_lsp.rs 11 12 91.67%
kclvm/sema/src/resolver/node.rs 22 27 81.48%
kclvm/sema/src/resolver/arg.rs 51 63 80.95%
Files with Coverage Reduction New Missed Lines %
kclvm/tools/src/LSP/src/inlay_hints.rs 3 92.31%
kclvm/sema/src/resolver/node.rs 3 81.3%
Totals Coverage Status
Change from base Build 10174326375: -0.001%
Covered Lines: 54205
Relevant Lines: 77098

💛 - Coveralls

@Peefy Peefy merged commit 20a35bc into kcl-lang:main Aug 1, 2024
12 checks passed
@Peefy Peefy deleted the enhance-dict-upgrade-schema-ty branch August 1, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants