Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix sema info about config entry left key and right value #1541

Merged
merged 9 commits into from
Aug 12, 2024

Conversation

He1pa
Copy link
Contributor

@He1pa He1pa commented Aug 5, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

https://github.com/kcl-lang/konfig/blob/main/models/kube/backend/server_backend.k
image

image

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

@coveralls
Copy link
Collaborator

coveralls commented Aug 6, 2024

Pull Request Test Coverage Report for Build 10348261178

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 128 of 144 (88.89%) changed or added relevant lines in 7 files are covered.
  • 80 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+0.02%) to 70.527%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/sema/src/core/global_state.rs 21 24 87.5%
kclvm/sema/src/core/scope.rs 24 37 64.86%
Files with Coverage Reduction New Missed Lines %
kclvm/sema/src/core/scope.rs 1 69.23%
kclvm/loader/src/lib.rs 1 82.14%
kclvm/tools/src/LSP/src/state.rs 12 92.57%
kclvm/tools/src/LSP/src/request.rs 66 63.43%
Totals Coverage Status
Change from base Build 10252244848: 0.02%
Covered Lines: 50427
Relevant Lines: 71500

💛 - Coveralls

kclvm/sema/src/core/scope.rs Show resolved Hide resolved
kclvm/loader/src/lib.rs Outdated Show resolved Hide resolved
kclvm/sema/src/advanced_resolver/node.rs Outdated Show resolved Hide resolved
kclvm/sema/src/core/scope.rs Outdated Show resolved Hide resolved
kclvm/sema/src/advanced_resolver/mod.rs Outdated Show resolved Hide resolved
@He1pa He1pa marked this pull request as draft August 9, 2024 06:33
Signed-off-by: he1pa <[email protected]>
@He1pa He1pa marked this pull request as ready for review August 9, 2024 07:52
Signed-off-by: he1pa <[email protected]>
@Peefy
Copy link
Contributor

Peefy commented Aug 12, 2024

Good Job! LGTM!

@Peefy Peefy merged commit 7487a8b into kcl-lang:main Aug 12, 2024
8 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants