Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add the prefix schema to the name of the document symbol #1562

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

He1pa
Copy link
Contributor

@He1pa He1pa commented Aug 13, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

2. What is the scope of this PR (e.g. component or file name):

kclvm/tools/src/LSP/src/document_symbol.rs

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

Add the prefix schema to the name of the document symbol. Avoid new a document symbol with empty string ""

https://github.com/microsoft/vscode/blob/922413f6d97e16c05b565398f33d95c306b1ceb7/src/vs/workbench/api/common/extHostTypes.ts#L1384

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

@He1pa He1pa added the lsp label Aug 13, 2024
Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link
Collaborator

coveralls commented Aug 13, 2024

Pull Request Test Coverage Report for Build 10366392255

Details

  • 5 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.002%) to 70.529%

Files with Coverage Reduction New Missed Lines %
kclvm/tools/src/LSP/src/inlay_hints.rs 3 92.31%
Totals Coverage Status
Change from base Build 10349377096: 0.002%
Covered Lines: 50432
Relevant Lines: 71505

💛 - Coveralls

@Peefy Peefy merged commit c3bbd4f into kcl-lang:main Aug 13, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]LSP document symbol error
3 participants