Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Clear the cache according to the changed module. #1581

Merged
merged 2 commits into from
Aug 19, 2024

Conversation

He1pa
Copy link
Contributor

@He1pa He1pa commented Aug 19, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

2. What is the scope of this PR (e.g. component or file name):

kclvm/sema/src/resolver/scope.rs

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

Analyze the invalid pkg(the pkg where the changed file is located and other pkgs that dependent on the changed pkg) from the given changed file

Previously, the analysis started from the main package to analyze the changed pkgs. Now, all modules in the program are analyzed.

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link
Collaborator

coveralls commented Aug 19, 2024

Pull Request Test Coverage Report for Build 10448739961

Details

  • 173 of 178 (97.19%) changed or added relevant lines in 5 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.08%) to 70.663%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/ast/src/ast.rs 7 8 87.5%
kclvm/sema/src/resolver/tests.rs 142 146 97.26%
Files with Coverage Reduction New Missed Lines %
kclvm/sema/src/resolver/scope.rs 1 77.04%
Totals Coverage Status
Change from base Build 10429265865: 0.08%
Covered Lines: 50769
Relevant Lines: 71847

💛 - Coveralls

@Peefy
Copy link
Contributor

Peefy commented Aug 19, 2024

Windows CI failed. cc @He1pa

Could you please add more information about this PR?

@Peefy Peefy merged commit 616bae5 into kcl-lang:main Aug 19, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants