Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add literal type default value pass and preprocess #1583

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Aug 19, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

Closes #1547

feat: add literal type default value pass and preprocess

Copy link
Contributor

@zong-zhe zong-zhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link
Collaborator

coveralls commented Aug 19, 2024

Pull Request Test Coverage Report for Build 10450605059

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 128 of 141 (90.78%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.07%) to 70.811%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/sema/src/resolver/node.rs 0 6 0.0%
kclvm/sema/src/pre_process/tests.rs 53 60 88.33%
Totals Coverage Status
Change from base Build 10449756338: 0.07%
Covered Lines: 51114
Relevant Lines: 72184

💛 - Coveralls

@Peefy Peefy merged commit 2a36798 into kcl-lang:main Aug 19, 2024
12 checks passed
@Peefy Peefy deleted the lit-ty-default-value-pass branch August 19, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DRY up static, unchangeable values in schemas
3 participants