feat: init lsp workspace when start language server #1584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 10482605243Details
💛 - Coveralls |
Signed-off-by: he1pa <[email protected]>
Signed-off-by: he1pa <[email protected]>
Signed-off-by: he1pa <[email protected]>
Signed-off-by: he1pa <[email protected]>
Signed-off-by: he1pa <[email protected]>
Peefy
reviewed
Aug 21, 2024
| let pathbuf = PathBuf::from(path); | ||
| let path = pathbuf.as_path(); | ||
| if path.is_dir() { | ||
| for entry in read_dir(path)? { |
There was a problem hiding this comment.
Why not merge these read_dir loops
shruti2522
pushed a commit
to shruti2522/kcl
that referenced
this pull request
Aug 26, 2024
* feat: init lsp workspace when start language server Signed-off-by: he1pa <[email protected]> * parse kcl.work Signed-off-by: he1pa <[email protected]> * fix window path prefix Signed-off-by: he1pa <[email protected]> * chore: fix typo Signed-off-by: he1pa <[email protected]> * fix typo Signed-off-by: he1pa <[email protected]> --------- Signed-off-by: he1pa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):
2. What is the scope of this PR (e.g. component or file name):
3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):
Init workspace when start language server
It will search by the following priority in LSP initialize_params.workspace_folders
If workspace is defined in kcl.work, parse kcl.work and generate multiple workspaces, otherwise only one
Now，the generated workspace is not used to process requests. All requests are still processed by the db, and the workspace and db will be merged later.