Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix find ref. Different types of symbols may have the same id. Use the position to determine whether it is def #1611

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

He1pa
Copy link
Contributor

@He1pa He1pa commented Aug 29, 2024

Different types of symbols may have the same id. Use the position to determine whether it is def

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

2. What is the scope of this PR (e.g. component or file name):

kclvm/tools/src/LSP/src/find_refs.rs

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

…se the position to determine whether it is def

Signed-off-by: he1pa <[email protected]>
@Peefy Peefy changed the title fix: fix find ref. … fix: fix find ref. Different types of symbols may have the same id. Use the position to determine whether it is def Aug 29, 2024
Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit a9e10db into kcl-lang:main Aug 29, 2024
10 of 12 checks passed
@coveralls
Copy link
Collaborator

coveralls commented Aug 29, 2024

Pull Request Test Coverage Report for Build 10616464889

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.02%) to 70.691%

Files with Coverage Reduction New Missed Lines %
kclvm/sema/src/resolver/mod.rs 1 99.06%
Totals Coverage Status
Change from base Build 10613781640: 0.02%
Covered Lines: 51064
Relevant Lines: 72236

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants