Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: find ref for ref symbol #1614

Merged
merged 2 commits into from
Sep 2, 2024
Merged

Conversation

He1pa
Copy link
Contributor

@He1pa He1pa commented Aug 30, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

2. What is the scope of this PR (e.g. component or file name):

kclvm/tools/src/LSP/src/find_refs.rs

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

a = 1
b = a
c = a

find ref for ref symble(a in line 2 and 3)

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy
Copy link
Contributor

Peefy commented Aug 30, 2024

CI failed.

@Peefy
Copy link
Contributor

Peefy commented Sep 2, 2024

CI failed. cc @He1pa

Signed-off-by: he1pa <[email protected]>
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 10668425476

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 19 of 19 (100.0%) changed or added relevant lines in 1 file are covered.
  • 246 unchanged lines in 8 files lost coverage.
  • Overall coverage increased (+0.02%) to 70.733%

Files with Coverage Reduction New Missed Lines %
kclvm/tools/src/LSP/src/tests.rs 1 98.6%
kclvm/tools/src/LSP/src/compile.rs 1 84.0%
kclvm/tools/src/LSP/src/find_refs.rs 3 89.83%
kclvm/parser/src/parser/stmt.rs 4 95.39%
kclvm/tools/src/LSP/src/error.rs 7 0.0%
kclvm/tools/src/LSP/src/state.rs 61 82.61%
kclvm/tools/src/LSP/src/request.rs 78 65.78%
kclvm/sema/src/advanced_resolver/node.rs 91 84.6%
Totals Coverage Status
Change from base Build 10618750775: 0.02%
Covered Lines: 51166
Relevant Lines: 72337

💛 - Coveralls

@Peefy Peefy merged commit f7fa125 into kcl-lang:main Sep 2, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants