Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enhance cycle deps error message #1639

Merged
merged 6 commits into from
Sep 14, 2024

Conversation

He1pa
Copy link
Contributor

@He1pa He1pa commented Sep 10, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

Optimize the error content, report errors on all nodes in cycle , and provide cycle information
image

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Job! LGTM!

Signed-off-by: he1pa <[email protected]>
Signed-off-by: he1pa <[email protected]>
kclvm/sema/src/resolver/global.rs Outdated Show resolved Hide resolved
kclvm/sema/src/resolver/import.rs Outdated Show resolved Hide resolved
@coveralls
Copy link
Collaborator

coveralls commented Sep 10, 2024

Pull Request Test Coverage Report for Build 10860315258

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 119 of 123 (96.75%) changed or added relevant lines in 5 files are covered.
  • 11 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.03%) to 70.588%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/sema/src/resolver/import.rs 26 27 96.3%
kclvm/sema/src/ty/context.rs 17 18 94.44%
kclvm/sema/src/resolver/global.rs 59 61 96.72%
Files with Coverage Reduction New Missed Lines %
kclvm/ast/src/pos.rs 11 68.75%
Totals Coverage Status
Change from base Build 10859818774: 0.03%
Covered Lines: 51270
Relevant Lines: 72633

💛 - Coveralls

kclvm/sema/src/resolver/global.rs Outdated Show resolved Hide resolved
kclvm/sema/src/resolver/global.rs Outdated Show resolved Hide resolved
kclvm/sema/src/resolver/global.rs Outdated Show resolved Hide resolved
kclvm/sema/src/resolver/global.rs Outdated Show resolved Hide resolved
kclvm/sema/src/resolver/global.rs Outdated Show resolved Hide resolved
kclvm/sema/src/ty/context.rs Outdated Show resolved Hide resolved
kclvm/sema/src/resolver/global.rs Outdated Show resolved Hide resolved
kclvm/sema/src/resolver/global.rs Outdated Show resolved Hide resolved
kclvm/sema/src/ty/mod.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit a8242c7 into kcl-lang:main Sep 14, 2024
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants